Re: Missing device IDs in rt2870

[Jakob Gruber]

On Tue, 28 Jul 2009 14:12:16 -0700
Greg KH <gregkh@xxxxxxx> wrote:

> On Tue, Jul 28, 2009 at 11:01:17PM +0200, Jakob Gruber wrote:
> > >From http://bugzilla.kernel.org/show_bug.cgi?id=13459#c3
> > 
> > In rt2870.h, there are 2 lists of USB devices. One is within 
> > 
> > #ifndef RT30xx
> > #endif
> > 
> > and the other in 
> > 
> > #ifdef RT30xx
> > #endif
> 
> That kind of implies that the 2870 driver should not support this
> device, right?

I think there's been a misunderstanding - I wasn't saying that the device ID is included in one block but not in another. I wanted to point out that I wasn't sure whether to add the ID to both lists or just the first one.

> 
> > 
> > Since I'm not sure whether to add the devices to both lists or only the first,
> > I'm posting a patch for both variations.
> > 
> > Patch 1, add devices only to first list:
> 
> Well, pick one :)
> 
> I'd prefer someone with one of these devices to test the patch and
> verify that it works before blindly applying.  Fair enough?

I own the Belkin device in question (0x050D,0x815C), and it worked perfectly with kernel 2.6.29 after adding the device ID to rt2870.h.
The patch is also included in the Archlinux kernel, see 
http://projects.archlinux.org/?p=linux-2.6-ARCH.git;a=tree;f=patches;hb=HEAD

I haven't tested rt2870 in 2.6.30 thoroughly because of this bug (http://bugzilla.kernel.org/show_bug.cgi?id=13638), which forces me to use the driver from the Ralink website instead of the kernel module.
However, I can confirm that - until running into the bug - the Belkin card also works in 2.6.30. 

A patch for adding the Belkin device ID is attached. I removed the other 2 IDs from http://bugzilla.kernel.org/show_bug.cgi?id=13459 since I do not own these devices and cannot verify them. The ID is only added to the "#ifndef RT30xx" block, same as the patch applied to the Archlinux kernel.

> 
> thanks,
> 
> greg k-h

Thanks for your work, it's appreciated.

-- 
Jakob Gruber <jakob.gruber@xxxxxxxxxxx>
From 9268d208454824d0b5aafff6875662191dceccff Mon Sep 17 00:00:00 2001
From: Jakob Gruber <jakob.gruber@xxxxxxxxxxx>
Date: Wed, 29 Jul 2009 16:53:15 +0200
Subject: [PATCH] RT2870 missing device ID

---
 drivers/staging/rt2870/rt2870.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/rt2870/rt2870.h b/drivers/staging/rt2870/rt2870.h
index 29e3b53..62b6ef2 100644
--- a/drivers/staging/rt2870/rt2870.h
+++ b/drivers/staging/rt2870/rt2870.h
@@ -99,6 +99,7 @@
 	{USB_DEVICE(0x14B2,0x3C07)}, /* AL */			\
 	{USB_DEVICE(0x14B2,0x3C12)}, /* AL */           \
 	{USB_DEVICE(0x050D,0x8053)}, /* Belkin */		\
+	{USB_DEVICE(0x050D,0x815C)}, /* Belkin */		\
 	{USB_DEVICE(0x14B2,0x3C23)}, /* Airlink */		\
 	{USB_DEVICE(0x14B2,0x3C27)}, /* Airlink */		\
 	{USB_DEVICE(0x07AA,0x002F)}, /* Corega */		\
-- 
1.6.3.3