Re: [RFC][patch 00/12] clocksource / timekeeping rework V2

From: Daniel Walker
Date: Wed Jul 29 2009 - 13:17:19 EST


On Wed, 2009-07-29 at 19:09 +0200, Martin Schwidefsky wrote:
> On Wed, 29 Jul 2009 11:02:21 -0600
> dwalker@xxxxxxxxxx wrote:
>
> > On Wed, 2009-07-29 at 18:50 +0200, Martin Schwidefsky wrote:
> >
> > > void clocksource_change_rating(struct clocksource *cs, int rating)
> >
> > > the two functions do different things. What exactly is the idea you've
> > > got in mind?
> >
> > It's only the case when the rating goes to zero .. That makes the
> > clocksource unusable, which is very much like unregistering it..
>
> True, the clocksource code won't pick the clock any more as long as
> there is an alternative clock available. It still shows up in the list
> of clocks though and you can do an override with it.

I'm not sure allowing that type of override a good idea tho .. I don't
think it's considered a usable clock when the rating goes to zero.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/