Re: [linux-cifs-client] [PATCH] cifs: reinstate original behavior when uid=/gid= options are specified

From: Jeff Layton
Date: Fri Jul 31 2009 - 17:12:49 EST


On Fri, 31 Jul 2009 14:26:15 -0500
Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> wrote:

> Should override_uid and override_gid be initialized to 1 so that if
> uid and/or gid
> are specified and none of the options, either forceuid/gid and or
> noforceuid/gid are
> specified, the vol-> override defaults to 1 (i.e. forceuid/gid)?
>

No, I'm using -1 as an indicator of "uninitialized". It's still
considered "true" when cast to a bool (which is what vol->override_*
actually are). That's how I can tell if someone specified forceuid with
no uid= option.
--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/