Re: [PATCH v2] regulator: Add GPIO enable control to fixed voltage regulator driver

From: Roger Quadros
Date: Sat Aug 01 2009 - 01:58:02 EST


On Sat, Aug 1, 2009 at 12:44 AM, Mark
Brown<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Jul 31, 2009 at 11:32:32PM +0300, Roger Quadros wrote:
>
>> Not having gpio_get_direction() in gpiolib is a limitation I think.
>> Can we just do the following for now ? (i.e. disable regulator by default)
>> Will there be any glitch? If yes, then how?
>
> If you're going to do this then like I say you should make the default
> state controllable by platform data.  If we unconditionally disable the
> regulator then if, for example, the regulator is controlling the display
> backlight and it's on when Linux get controls then the user will see the
> backlight blink off then on during startup.
>

OK I will add another bit for this in fixed_voltage_config.

Do we need to check whether CONFIG_GPIOLIB is available? or do we need
to explicitly
select it in Kconfig?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/