Re: [PATCH] pcnet32: remove superfluous NULL pointer check inpcnet32_probe1()

From: David Miller
Date: Sun Aug 02 2009 - 15:30:26 EST


From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Date: Thu, 30 Jul 2009 23:19:17 +0200

> From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> Subject: [PATCH] pcnet32: remove superfluous NULL pointer check in pcnet32_probe1()
>
> Move the debug printk() into the proper place and remove superfluous
> NULL pointer check in pcnet32_probe1().
>
> This takes care of the following entry from Dan's list:
>
> drivers/net/pcnet32.c +1889 pcnet32_probe1(298) warning: variable derefenced before check 'pdev'
>
> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

Applied, but please CC: netdev@xxxxxxxxxxxxxxx for all future
network driver patches so that it gets properly tracked in
patchwork. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/