Re: [PATCH 1/1 tip] perf top: Move hard coded list to/etc/perfconfig/symbols.skip

[Arnaldo Carvalho de Melo]

Em Sun, Aug 02, 2009 at 09:55:33PM +0200, Ingo Molnar escreveu:
> 
> * Ray Lee <ray-lk@xxxxxxxxxxxxx> wrote:
> 
> > On Mon, Jul 27, 2009 at 5:10 PM, Arnaldo Carvalho de
> > Melo<acme@xxxxxxxxxx> wrote:
> > > This also paves the way to add more symbol lists to be filtered out,
> > > spinlock anyone?
> > 
> > Generally, the way I've found is best to handle things like this is to either:
> > 
> > A. Have a fall-back list to use if the file isn't found, or
> > B. Start with the fall-back list of symbols to filter, then add to
> > them via /etc/... and ~/.perf/...
> > 
> > I like approaching things from the 'everything works even in a
> > broken/hasty installation' point of view, and it's paid off for me.
> > Sane defaults are a wonderfully useful thing.
> 
> Agreed.
> 
> Also, i'd not pollute /etc just yet, please lets define a good 
> default built-in list like we have now, and perhaps enable the 
> extension of it via .perf/config.
> 
> Tools should work well by default.

OK, I'll rework the patch and resubmit it.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/