Re: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3

[Alan Cox]

> This guideline doesn't appear in Documentation/CodingStyle.  Should it?

Possibly - the thing is there are several cases where its used
deliberately the other way around.

>> >> +	struct memrar_allocator *allocator = 0;
> >
> >It is recommended to separate definition,
> >and assignment.
> >So this should look like this:
> >
> >	struct memrar_allocator *allocator;
> >
> >	allocator = 0;
> 
> Okay, I'll fix that, too.  Should this go into Documentation/CodingStyle, too?

This is nonsense to put it politely. It's a pointer so it should be =
NULL but the formatting is just fine. It's not in the coding style
because its bunkum 8)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/