Re: [PATCH 1/2] ds2760: switch to new dev_pm_ops

[Frans Pop]

Daniel Mack wrote:
> +static struct dev_pm_ops ds2760_battery_pm_ops = {
> +       .suspend        = ds2760_battery_suspend,
> +       .resume         = ds2760_battery_resume,
> +};

Just to make sure...

Have you followed the earlier discussions on dev_pm_ops conversions and 
are you aware that if done like this the driver no longer supports 
hibernation?

If omitting hibernation is intentional, it should probably be justified in 
the commit log.

See http://lkml.org/lkml/2009/7/25/118 for background.

Same goes for your patch for w1_gpio of course.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/