Re: [PATCH 1/3] arch/powerpc: Add kmalloc NULL tests

From: Kumar Gala
Date: Thu Aug 06 2009 - 22:27:20 EST



On Aug 6, 2009, at 3:04 PM, Julia Lawall wrote:

From: Julia Lawall <julia@xxxxxxx>

Check that the result of kmalloc/kzalloc is not NULL before dereferencing it.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression *x;
identifier f;
constant char *C;
@@

x = \(kmalloc\|kcalloc\|kzalloc\)(...);
... when != x == NULL
when != x != NULL
when != (x || ...)
(
kfree(x)
|
f(...,C,...,x,...)
|
*f(...,x,...)
|
*x->f
)
// </smpl>

Signed-off-by: Julia Lawall <julia@xxxxxxx>

---
arch/powerpc/sysdev/fsl_rio.c | 18 ++++++++++++++----
1 files changed, 14 insertions(+), 4 deletions(-)


applied to next

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/