Re: [patch] x86, perf_counter, bts: add bts to perf_counter

From: Peter Zijlstra
Date: Fri Aug 07 2009 - 07:46:03 EST


On Fri, 2009-08-07 at 09:22 +0200, Markus Metzger wrote:
> @@ -721,9 +903,13 @@ static int __hw_perf_counter_init(struct
> err = 0;
> if (!atomic_inc_not_zero(&active_counters)) {
> mutex_lock(&pmc_reserve_mutex);
> - if (atomic_read(&active_counters) == 0 && !reserve_pmc_hardware())
> - err = -EBUSY;
> - else
> + if (atomic_read(&active_counters) == 0) {
> + if (!reserve_pmc_hardware())
> + err = -EBUSY;
> + else
> + reserve_bts_hardware();
> + }
> + if (!err)
> atomic_inc(&active_counters);
> mutex_unlock(&pmc_reserve_mutex);
> }

You loose the reserve_bts_hardware() error case there.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/