mISDN: potential null dereference in dsp_cmx_send_member()

From: Dan Carpenter
Date: Fri Aug 07 2009 - 08:13:58 EST


Hello,

I am testing a source analysis tool (http://repo.or.cz/w/smatch.git)
and it generates a warning in dsp_cmx_send_member().

The problem is that on line 1327 we verify that dsp->conf is non null but
on line 1329 we assume that it is non null and dereference it without
checking.

drivers/isdn/mISDN/dsp_cmx.c
1327 if (dsp->conf && dsp->conf->software && dsp->conf->hardware)
1328 tx_data_only = 1;
1329 if (dsp->conf->software && dsp->echo.hardware)
1330 tx_data_only = 1;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/