Re: [PATCH 2/8] Regulator: Adding header file for TPS65023

[Felipe Balbi]

On Fri, Aug 07, 2009 at 05:55:58PM +0200, ext Mark Brown wrote:
> On Fri, Aug 07, 2009 at 08:55:36PM +0530, Anuj Aggarwal wrote:
> 
> This is OK but since you'll need to resubmit anyway it might be nice to
> consider moving the register & bitfield definitions into the driver file
> since they can't be used by any other code.
> 
> > +/* DCDC's */
> 
> Extra ' here :)

I agree, there shouldn't be need for this file.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/