Re: [PATCH 6/8] Regulator: Add board-omap35x-pmic.c toarch/arm/mach-omap2/

[Mark Brown]

On Fri, Aug 07, 2009 at 08:59:26PM +0530, Anuj Aggarwal wrote:

> Added arch/arm/mach-omap2/board-omap35x-pmic.c file which will
> have the board specific information for different regulators
> and will do the regulator initialization depending on the one
> which is available.

Should this have an "evm" or something in the filename, possibly?  There
will be some boards that aren't so directly cloned from the reference
designs.

> +static inline int detect_pmic(void)
> +{
> +#if defined(CONFIG_TWL4030_CORE)
> +	flag_pmic_twl4030 = 1;
> +#endif

This isn't actually detecting anything on the board, it's just flagging
the things that have drivers built in.  Will everything continue to work
OK if support for more than one of the PMICs is built into the kernel or
will things break?  If they'll break you might want to have something to
detect that and flag it up.

> +int oma35x_pmic_init(void)
> +{

Typo there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/