[PATCH 1/3] drivers/isdn/hisax: Correct use of request_region/request_mem_region

From: Julia Lawall
Date: Sun Aug 09 2009 - 03:43:33 EST


From: Julia Lawall <julia@xxxxxxx>

request_region should be used with release_region, not request_mem_region.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r1@
expression start;
@@

request_region(start,...)

@b1@
expression r1.start;
@@

request_mem_region(start,...)

@depends on !b1@
expression r1.start;
expression E;
@@

- release_mem_region
+ release_region
(start,E)
// </smpl>

Signed-off-by: Julia Lawall <julia@xxxxxxx>

---
drivers/isdn/hisax/isurf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -u -p a/drivers/isdn/hisax/isurf.c b/drivers/isdn/hisax/isurf.c
--- a/drivers/isdn/hisax/isurf.c
+++ b/drivers/isdn/hisax/isurf.c
@@ -125,7 +125,7 @@ release_io_isurf(struct IsdnCardState *c
{
release_region(cs->hw.isurf.reset, 1);
iounmap(cs->hw.isurf.isar);
- release_mem_region(cs->hw.isurf.phymem, ISURF_IOMEM_SIZE);
+ release_region(cs->hw.isurf.phymem, ISURF_IOMEM_SIZE);
}

static void
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/