[PATCH 3/5] inotify: use container_of instead of casting

From: Eric Paris
Date: Sun Aug 09 2009 - 17:59:56 EST


inotify_free_mark casts directly from an fsnotify_mark_entry to an
inotify_inode_mark_entry. This works, but should use container_of instead
for future proofing.

Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>
---

fs/notify/inotify/inotify_user.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
index c3086b0..fb38e73 100644
--- a/fs/notify/inotify/inotify_user.c
+++ b/fs/notify/inotify/inotify_user.c
@@ -424,7 +424,9 @@ skip_send_ignore:
/* ding dong the mark is dead */
static void inotify_free_mark(struct fsnotify_mark_entry *entry)
{
- struct inotify_inode_mark_entry *ientry = (struct inotify_inode_mark_entry *)entry;
+ struct inotify_inode_mark_entry *ientry;
+
+ ientry = container_of(entry, struct inotify_inode_mark_entry, fsn_entry);

kmem_cache_free(inotify_inode_mark_cachep, ientry);
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/