RE: [PATCH] perf_counter: Fix a race on perf_counter_ctx

[Metzger, Markus T]

>-----Original Message-----
>From: Metzger, Markus T
>Sent: Tuesday, August 11, 2009 8:34 AM
>To: 'Ingo Molnar'
>Cc: Peter Zijlstra; tglx@xxxxxxxxxxxxx; hpa@xxxxxxxxx; markus.t.metzger@xxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx; Paul Mackerras
>Subject: RE: [PATCH] perf_counter: Fix a race on perf_counter_ctx
>
>>-----Original Message-----
>>From: Ingo Molnar [mailto:mingo@xxxxxxx]
>>Sent: Monday, August 10, 2009 3:46 PM
>>To: Metzger, Markus T
>>Cc: Peter Zijlstra; tglx@xxxxxxxxxxxxx; hpa@xxxxxxxxx; markus.t.metzger@xxxxxxxxx; linux-
>>kernel@xxxxxxxxxxxxxxx; Paul Mackerras
>>Subject: Re: [PATCH] perf_counter: Fix a race on perf_counter_ctx
>>
>>
>>* Metzger, Markus T <markus.t.metzger@xxxxxxxxx> wrote:
>>
>>> I've been using some old version of perf. When I try to build the
>>> version for the latest -tip, I get the following build error:
>>>
>>> builtin-annotate.o: In function `print_summary':
>>> /home/markus/linux/git-tip/tools/perf/builtin-annotate.c:1211: undefined reference to `rb_first'
>>> /home/markus/linux/git-tip/tools/perf/builtin-annotate.c:1223: undefined reference to `rb_next'
>>> builtin-annotate.o: In function `insert_source_line':
>>
>>Weird. How do you build perf? Do you do:
>>
>>  cd tools/perf/
>>  make
>>
>>? does your build directory have the ../../lib/rbtree.c file?
>
>Yes and yes.


The rbtree object file does not seem to be an ELF file (see below).

When I have gcc generate an assembly file and generate the object with a
separate call to gcc, I can build perf.

When I say "perf record -f -e branches -c 1", the kernel hangs.

You said that this is working for you?

regards,
markus.

----

[markus@labpc212 perf]$ gcc --version
gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7)
Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[markus@labpc212 perf]$ file *.o util/*.o
builtin-annotate.o:   ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
builtin-help.o:       ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
builtin-list.o:       ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
builtin-record.o:     ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
builtin-report.o:     ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
builtin-stat.o:       ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
builtin-top.o:        ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
perf.o:               ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/abspath.o:       ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/alias.o:         ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/callchain.o:     ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/color.o:         ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/config.o:        ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/ctype.o:         ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/environment.o:   ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/exec_cmd.o:      ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/header.o:        ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/help.o:          ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/levenshtein.o:   ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/module.o:        ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/pager.o:         ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/parse-events.o:  ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/parse-options.o: ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/path.o:          ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/quote.o:         ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/rbtree.o:        data
util/run-command.o:   ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/sigchain.o:      ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/strbuf.o:        ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/string.o:        ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/strlist.o:       data
util/symbol.o:        ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/usage.o:         ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/values.o:        ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
util/wrapper.o:       ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
[markus@labpc212 perf]$
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/