Re: [PATCH 1/5] drivers/mfd: Add Freescale MC13783 driver

[Mark Brown]

On Tue, Aug 11, 2009 at 11:07:43AM +0200, Sascha Hauer wrote:

> +/*
> + * Register a client device.  This is non-fatal since there is no need to
> + * fail the entire device init due to a single platform device failing.
> + */
> +static void mc13783_client_dev_register(struct mc13783 *mc13783,
> +				       const char *name,
> +				       struct platform_device **pdev)

Some of this code is looking distinctly familiar :)

> +#define	SW_SW1A		0
> +#define	SW_SW1B		1

This and the other defines following look like they should probably be
namespaced.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/