Re: [PATCH 12/14] scsi: use printk_once

[James Bottomley]

On Tue, 2009-08-11 at 09:46 -0700, Roland Dreier wrote:
> > > -	static int vers_printed;
>  > > -
>  > > -	if (!vers_printed) {
>  > > -		printk(KERN_INFO "%s", version);
>  > > -		vers_printed = 1;
>  > > -	}
>  > > +	printk_once(KERN_INFO "%s", version);
> 
>  > There's really no point to this beyond code churn.  Both patterns are
>  > correct uses so conversion buys us nothing.
> 
> It's a pretty small gain but I do think 6 lines -> 1 line does have value.

Not at the expense of churning the code base of marginal drivers.

I'm not entirely convinced this is a good pattern to begin with.  If you
add too many patterns you're effectively developing an overly complex
development language and rule set.  Even if I go with this on the basis
of readability (as you say, one line for six), then I still don't think
we should churn the code base to convert correct open coding to it; we
should just use it ongoing.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/