Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

From: Michael Barkowski
Date: Wed Aug 12 2009 - 17:01:27 EST


Anton Vorontsov wrote:
> On Wed, Aug 12, 2009 at 04:45:55PM -0400, Michael Barkowski wrote:
>> Hello Anton,
>>
>> Is m25p_probe now valid with dev.platform_data == NULL, for of platforms?
>>
>> Then shouldn't you have the following change as well, near the end of
>> the function?
>>
>> - } else if (data->nr_parts)
>> + } else if (data && data->nr_parts)
>> dev_warn(&spi->dev, "ignoring %d default partitions on %s\n",
>> data->nr_parts, data->name);
>>
>> Or am I misunderstanding something?
>
> Yeah, you missed this patch:
> http://patchwork.kernel.org/patch/38179/
>
>
> Thanks,
>

Beautiful - thanks - sorry to interrupt

--
Michael Barkowski
905-482-4577
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/