Re: [PATCH] net: Fix spinlock use in alloc_netdev_mq()

From: David Miller
Date: Wed Aug 12 2009 - 19:44:14 EST


From: Jiri Pirko <jpirko@xxxxxxxxxx>
Date: Thu, 6 Aug 2009 10:31:02 +0200

> Hmm, I see your point here. Eric previously posted patch which moved spin lock
> init into alloc_netdev_mq(). But he was worried about having it here and
> netdev_set_addr_lockdep_class() in register_netdevice() (because before
> dev_unicast_init() dev->type is not set). So how about the following patch?

Well, because of those potential late dev->type settings we
can't do things this way. And I believe those in fact do happen.

So I'm tossing this patch, I wouldn't have applied it to net-2.6
anyways, as it's net-next-2.6 material :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/