Re: [PATCH 2/2] x86: Clear incorrectly forced X86_FEATURE_LAHF_LM flag

[Brian Gerst]

On Thu, Aug 13, 2009 at 8:31 AM, Borislav Petkov<borislav.petkov@xxxxxxx> wrote:
> From: Kevin Winchester <kjwinchester@xxxxxxxxx>
>
> Due to an erratum with certain AMD Athlon 64 processors, the BIOS may
> need to force enable the LAHF_LM capability. ÂUnfortunately, in at
> least one case, the BIOS does this even for processors that do not
> support the functionality.
>
> Add a specific check that will clear the feature bit for processors
> known not to support the LAHF/SAHF instructions.
>
> Borislav: turn off cpuid bit.
>
> Signed-off-by: Kevin Winchester <kjwinchester@xxxxxxxxx>
> Signed-off-by: Borislav Petkov <borislav.petkov@xxxxxxx>
> ---
> Âarch/x86/kernel/cpu/amd.c | Â 16 ++++++++++++++++
> Â1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index e2485b0..9cd6fc7 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -400,6 +400,22 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
> Â Â Â Â Â Â Â Âlevel = cpuid_eax(1);
> Â Â Â Â Â Â Â Âif((level >= 0x0f48 && level < 0x0f50) || level >= 0x0f58)
> Â Â Â Â Â Â Â Â Â Â Â Âset_cpu_cap(c, X86_FEATURE_REP_GOOD);
> +
> + Â Â Â Â Â Â Â /*
> + Â Â Â Â Â Â Â Â* Some BIOSes incorrectly force this feature, but only K8
> + Â Â Â Â Â Â Â Â* revision D (model = 0x14) and later actually support it.
> + Â Â Â Â Â Â Â Â*/
> + Â Â Â Â Â Â Â if (c->x86_model < 0x14) {

Shouldn't you test that the flag is actually set before trying to clear it?

> + Â Â Â Â Â Â Â Â Â Â Â u64 val;
> +
> + Â Â Â Â Â Â Â Â Â Â Â clear_cpu_cap(c, X86_FEATURE_LAHF_LM);
> + Â Â Â Â Â Â Â Â Â Â Â if (!rdmsrl_amd_safe(0xc001100d, &val)) {
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â val &= ~(1ULL << 32);
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â wrmsr_amd_safe(0xc001100d, (u32) val,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â(u32)(val >> 32));
> + Â Â Â Â Â Â Â Â Â Â Â }
> + Â Â Â Â Â Â Â }
> +
> Â Â Â Â}
> Â Â Â Âif (c->x86 == 0x10 || c->x86 == 0x11)
> Â Â Â Â Â Â Â Âset_cpu_cap(c, X86_FEATURE_REP_GOOD);
> --
> 1.6.3.3
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/