Re: [PATCH] arch-x86-pci-swiotlb-cleanup-patch

From: Ingo Molnar
Date: Thu Aug 13 2009 - 16:30:15 EST



* Marin Mitov <mitov@xxxxxxxxxxx> wrote:

> Hi all,
>
> This is a simple cleanup patch for arch/x86/kernel/pci-swiotlb.c
> file.
>
> Deleted functions are already in lib/swiotlb.c, so no need to be
> duplicated.
>
> The patch is against linux-2.6.31-rc5, compile/run tested on
> x86_64.
>
> Best regards,
>
> Marin Mitov
>
> Signed-off-by: Marin Mitov <mitov@xxxxxxxxxxx>
>
> =====================================================
> --- a/arch/x86/kernel/pci-swiotlb.c 2009-08-13 16:05:28.000000000 +0300
> +++ b/arch/x86/kernel/pci-swiotlb.c 2009-08-13 16:13:09.000000000 +0300
> @@ -13,31 +13,6 @@
>
> int swiotlb __read_mostly;
>
> -void * __init swiotlb_alloc_boot(size_t size, unsigned long nslabs)
> -{
> - return alloc_bootmem_low_pages(size);
> -}
> -
> -void *swiotlb_alloc(unsigned order, unsigned long nslabs)
> -{
> - return (void *)__get_free_pages(GFP_DMA | __GFP_NOWARN, order);
> -}
> [...]

Fujita Tomonori has already done this in these swiotlb commits:

bb52196: swiotlb: remove unused swiotlb_alloc()
3885123: swiotlb: remove unused swiotlb_alloc_boot()

about a month ago. You can find those changes in -tip:

http://people.redhat.com/mingo/tip.git/README

and in linux-next as well.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/