Re: [patch 28/74] thinkpad-acpi: fix incorrect use of TPACPI_BRGHT_MODE_ECNVRAM

[Stefan Lippers-Hollmann]

Hi

On Friday 14 August 2009, Stefan Lippers-Hollmann wrote:
[...]
> > From: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> > 
> > commit 59fe4fe34d7afdf63208124f313be9056feaa2f4 upstream.
[...]
> > This fixes a regression in 2.6.30, bugzilla #13826
> 
> As already reported in [1] and confirmed by hmh in [2], this patch breaks 
> compiling thinkpad_acpi in 2.6.31-rc5.

ERR, 2.6.30.5-rc1 of course, it's fine in linux-2.6 HEAD/ 2.6.31-rc5[-git9]
as that contains the additionally required patches.

Sorry about the confusion.
	Stefan Lippers-Hollmann


[...]
>   CC [M]  drivers/platform/x86/hp-wmi.o
>   CC [M]  drivers/platform/x86/sony-laptop.o
>   CC [M]  drivers/platform/x86/thinkpad_acpi.o
> drivers/platform/x86/thinkpad_acpi.c:5769: error: array type has incomplete element type
> drivers/platform/x86/thinkpad_acpi.c:5771: error: implicit declaration of function 'TPACPI_Q_IBM'
> drivers/platform/x86/thinkpad_acpi.c: In function 'brightness_init':
> drivers/platform/x86/thinkpad_acpi.c:5799: error: implicit declaration of function 'tpacpi_check_quirks'
> drivers/platform/x86/thinkpad_acpi.c:5800: warning: type defaults to 'int' in declaration of 'type name'
> drivers/platform/x86/thinkpad_acpi.c:5800: warning: type defaults to 'int' in declaration of 'type name'
> drivers/platform/x86/thinkpad_acpi.c:5800: error: size of array 'type name' is negative
> make[6]: *** [drivers/platform/x86/thinkpad_acpi.o] Error 1
> make[5]: *** [drivers/platform/x86] Error 2
> make[4]: *** [drivers/platform] Error 2
> make[3]: *** [drivers] Error 2
> 
> Regards
> 	Stefan Lippers-Hollmann
> 
> [1]	From: "Stefan Lippers-Hollmann" <s.L-H@xxxxxx>
> 	Date: Fri, 7 Aug 2009 01:08:10 +0200
> 	Subject: Re: patch thinkpad-acpi-fix-incorrect-use-of-tpacpi_brght_mode_ecnvram.patch added to 2.6.30-stable tree
> 	Message-Id: <200908070108.15095.s.L-H@xxxxxx>
> 	http://lkml.indiana.edu/hypermail/linux/kernel/0908.0/02520.html
> [2]	From: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> 	Date: Thu, 6 Aug 2009 20:31:11 -0300
> 	Subject: Re: patch thinkpad-acpi-fix-incorrect-use-of-tpacpi_brght_mode_ecnvram.patch added to 2.6.30-stable tree
> 	Message-ID: <20090806233111.GB14381@xxxxxxxxxxxxxxxxxxxxx>
> 	http://lkml.indiana.edu/hypermail/linux/kernel/0908.0/02526.html
> 
> > Signed-off-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> > Reported-by: Tobias Diedrich <ranma+kernel@xxxxxxxxxxxx>
> > Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/