Re: [PATCH 1/1] intel_txt: to fix build errors of CONFIG_ACPI_SLEEP

[H. Peter Anvin]

On 08/13/2009 07:06 PM, Wang, Shane wrote:
> I agree with hpa, considering TXT doesnot depends on acpi sleep.
> 
> However, for hpa's patch, set_mac_regions() is for S3 only. I am wondering whether we should enlarge the range of CONFIG_ACPI_SLEEP in set_mac_regions().
> Certainly, for code cleanness, this patch is fine since the assignment
> 
> 
> takes effect but tboot->mac_regions[] will never be used without S3.
> 

OK, that makes it easier.  We should just conditionalize the whole thing
then.  A lot cleaner than #ifdefing the individual assignments.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/