Re: [PATCH 2/2] perf tools: Add a general option to enable rawsample records

[Frederic Weisbecker]

Sorry, please ignore this one, it has been resent by mistake :-(

On Fri, Aug 14, 2009 at 12:05:00PM +0200, Frederic Weisbecker wrote:
> While we can enable the perf sample records per tracepoint counter,
> we may also want to enable this option for every tracepoint
> counters to open, so that we don't need to add a :record flag
> for all of them.
> 
> Add the -R, --raw-samples options for this purpose.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Mike Galbraith <efault@xxxxxx>
> ---
>  tools/perf/builtin-record.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 3be0301..e67c4fa 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -35,6 +35,7 @@ static int			output;
>  static const char		*output_name			= "perf.data";
>  static int			group				= 0;
>  static unsigned int		realtime_prio			= 0;
> +static int			raw_samples			= 0;
>  static int			system_wide			= 0;
>  static int			profile_cpu			= -1;
>  static pid_t			target_pid			= -1;
> @@ -400,6 +401,8 @@ static void create_counter(int counter, int cpu, pid_t pid)
>  	if (call_graph)
>  		attr->sample_type	|= PERF_SAMPLE_CALLCHAIN;
>  
> +	if (raw_samples)
> +		attr->sample_type	|= PERF_SAMPLE_RAW;
>  
>  	attr->mmap		= track;
>  	attr->comm		= track;
> @@ -632,6 +635,8 @@ static const struct option options[] = {
>  		    "record events on existing pid"),
>  	OPT_INTEGER('r', "realtime", &realtime_prio,
>  		    "collect data with this RT SCHED_FIFO priority"),
> +	OPT_BOOLEAN('R', "raw-samples", &raw_samples,
> +		    "collect raw sample records from all opened counters"),
>  	OPT_BOOLEAN('a', "all-cpus", &system_wide,
>  			    "system-wide collection from all CPUs"),
>  	OPT_BOOLEAN('A', "append", &append_file,
> -- 
> 1.6.2.3
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/