Re: [PATCH -rt] Fix kmap_high_get()

From: Uwe Kleine-König
Date: Fri Aug 14 2009 - 16:13:58 EST


Hello,

On Fri, Aug 14, 2009 at 11:58:59AM -0400, Nicolas Pitre wrote:
> On Fri, 14 Aug 2009, Peter Zijlstra wrote:
>
> > As to the patch, its not quite right.
... on irc Peter and me agreed it's not that wrong :-) Anyhow, I merged
the two patches to get the benefits from both. See below.

> > From what I understand kmap_high_get() is used to pin a page's kmap iff
> > it has one, whereas the result of your patch seems to be that it'll
> > actually create one if its not found.
>
> I don't have enough context to review this patch, but your understanding
> of the kmap_high_get() purpose is right.
The patch with all it's dependencies based on -rc6 is available on

git://git.pengutronix.de/git/ukl/linux-2.6.git kmap-testing

Niko: Your review would be very welcome because neither Peter nor me
have a machine with highmem.

Best regards
Uwe