Re: [PATCH] fs/proc/base.c: fix proc_fault_inject_write() inputsanity check

From: Vincent Li
Date: Mon Aug 17 2009 - 12:44:33 EST


On Mon, 17 Aug 2009, Amerigo Wang wrote:

> On Fri, Aug 14, 2009 at 01:18:40PM -0700, Vincent Li wrote:
> >Remove obfuscated zero-length input check and return -EINVAL instead of -EIO error
> >to make the error message clear to user. Add whitespace stripping. No functionality changes.
>
> If so, why not introduce a new wrapper which is simply strstrip+simple_strtol?
> Now, at least it has two users.

The first patch I sent used strstrip + strict_strtol, I am not sure if it
is neccesary.

Vincent Li
Biomedical Research Center
University of British Columbia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/