Re: [PATCH] intel-iommu: Work around yet another BIOS bug

[Andrew Morton]

On Thu, 20 Aug 2009 09:01:58 +0100 David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:

> +	if (iommu->cap == (uint64_t)-1 && iommu->ecap == (uint64_t)-1) {
> +		/* Promote an attitude of violence to a BIOS engineer today */
> +		WARN(1, "Your BIOS is broken; DMAR reported at address %llx returns all ones!\n"
> +		     "BIOS vendor: %s; Ver: %s; Product Version: %s\n",
> +		     drhd->reg_base_addr,

Printing a u64 with %ll will (still) generate a warning on four architectures.

> +		     dmi_get_system_info(DMI_BIOS_VENDOR),
> +		     dmi_get_system_info(DMI_BIOS_VERSION),
> +		     dmi_get_system_info(DMI_PRODUCT_VERSION));
> +		goto err_unmap;
> +	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/