Re: [GIT PULL] Fix Xen boot with CONFIG_CC_STACKPROTECTOR

From: Ingo Molnar
Date: Thu Aug 20 2009 - 06:07:26 EST



* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Hi Ingo,
>
> Here's a couple of little changes which prevents an early boot crash
> under Xen, due to the stackprotector preamble using segment registers
> before they're set up. I only need to disable stackprotector for a
> handful of functions, but unfortunately it looks like it can only be
> disabled on a per-file basis.
>
> Thanks,
> J
>
> The following changes since commit 64f1607ffbbc772685733ea63e6f7f4183df1b16:
> Linus Torvalds (1):
> Linux 2.6.31-rc6
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git bugfix
>
> Jeremy Fitzhardinge (2):
> x86: make sure load_percpu_segment has no stackprotector
> xen: rearrange things to fix stackprotector
>
> arch/x86/kernel/cpu/Makefile | 4 ++++
> arch/x86/xen/Makefile | 4 ++++
> arch/x86/xen/enlighten.c | 22 ++++++++++------------
> 3 files changed, 18 insertions(+), 12 deletions(-)

Pulled into tip:x86/urgent, thanks a lot Jeremy!

Btw., is there any way to turn off stackprotector on a
per function basis, a GCC attribute perhaps? That would
be preferable to turning it off for all of common.o.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/