Re: [RFC v6][PATCH 2/4] intel_txt: Intel(R) TXT reboot/halt shutdownsupport

[H. Peter Anvin]

On 08/20/2009 02:33 AM, Wang, Shane wrote:
> Hi Ingo & hpa,
> 
> I have made some change on the previous tboot patch to fix the build errors.
> Please comment.
> 
> Thanks.
> Shane
> 

This code addresses the build errors, but not in the right manner.

We should not have to have tboot-specific #ifdefs in tons and tons of
arch-generic files; we need to figure out how to move them into code
flow already in arch-specific code, or we need to very carefully figure
out what additional arch-specific operations are needed at a higher level.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/