Re: [PATCH 1/1] kcore-use-registerd-physmem-information-fix2

[KAMEZAWA Hiroyuki]

On Fri, 21 Aug 2009 09:36:08 +0200
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> Fix this compilation warning on x86_64:
> fs/proc/kcore.c: In function ‘kclist_add_private’:
> fs/proc/kcore.c:175: warning: comparison between pointer and integer
> 
Oh, thank you.

Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>


> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> ---
>  fs/proc/kcore.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
> index aabbc3a..98fcf17 100644
> --- a/fs/proc/kcore.c
> +++ b/fs/proc/kcore.c
> @@ -172,7 +172,7 @@ kclist_add_private(unsigned long pfn, unsigned long nr_pages, void *arg)
>  		ent->size = ULONG_MAX - ent->addr;
>  
>  	/* cut when vmalloc() area is higher than direct-map area */
> -	if (VMALLOC_START > __va(0)) {
> +	if (VMALLOC_START > (unsigned long)__va(0)) {
>  		if (ent->addr > VMALLOC_START)
>  			goto free_out;
>  		if (VMALLOC_START - ent->addr < ent->size)
> -- 
> 1.6.3.3
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/