Re: [PATCH] x86: properly annotate alternatives.c

From: Ingo Molnar
Date: Fri Aug 21 2009 - 16:09:28 EST



* Jan Beulich <JBeulich@xxxxxxxxxx> wrote:

> Some of the NOPs tables aren't used on 64-bits, quite some code and
> data is needed post-init for module loading only, and a couple of
> functions aren't used outside that file (i.e. can be static, and don't
> need to be exported).
>
> The change to __INITDATA/__INITRODATA is needed to avoid an assembler
> warning.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> ---
> arch/x86/include/asm/alternative.h | 7 ----
> arch/x86/kernel/alternative.c | 56 +++++++++++++++++++++----------------
> include/linux/init.h | 12 ++++++-
> 3 files changed, 42 insertions(+), 33 deletions(-)

looks like a nice improvement. Sam, what do you think?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/