Re: [patch 4/4 -mm] flex_array: add flex_array_shrink function

[Randy Dunlap]

On Fri, 21 Aug 2009 16:49:35 -0700 Andrew Morton wrote:

> On Fri, 21 Aug 2009 16:21:49 -0700 (PDT)
> David Rientjes <rientjes@xxxxxxxxxx> wrote:
> 
> > +/**
> > + * flex_array_shrink - free unused second-level pages
> > + *
> > + * Frees all second-level pages that consist solely of unused
> > + * elements.  Returns the number of pages freed.
> > + *
> > + * Locking must be provided by the caller.
> > + */
> > +int flex_array_shrink(struct flex_array *fa)
> 
> It's logical but afaik unconventional that none of the flex_array
> kerneldoc actually documents the `struct flex_array *fa' argument.

IF (big if) someone had used "make htmldocs" and checked it for errors/warnings,
(see 11. in Documentation/SubmitChecklist), this would have been flagged with:

Warning(some_filename.c:1012): No description found for parameter 'fa'


> We're all waiting with bated breath to see who will be the first to use
> flex_array in live code.
> 
> Sometime we'll need to move flex_array.o from lib-y to obj-y and fill
> it up with EXPORT_SYMBOL()s.  2.6.32 I expect.


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/