Re: [Patch 1/8] kexec: allow to shrink reserved memory

From: Andrew Morton
Date: Fri Aug 21 2009 - 20:18:51 EST


On Fri, 21 Aug 2009 02:54:25 -0400
Amerigo Wang <amwang@xxxxxxxxxx> wrote:

> +size_t get_crash_memory_size(void)
> +int shrink_crash_memory(unsigned long new_size)

These aren't particualrly well-chosen global identifiers. It would be
better if they were called crash_*() or kexec_*(), to make it clear
which subsystem they belong to.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/