Re: Synaptics touchscreen for HTC Dream: check that smbus isavailable

From: Pavel Machek
Date: Sat Aug 22 2009 - 08:07:33 EST


On Mon 2009-08-17 16:47:59, Andrew Morton wrote:
> On Sat, 8 Aug 2009 15:40:50 +0200
> Pavel Machek <pavel@xxxxxx> wrote:
>
> > > >> Because this driver is using smbus i2c apis, it will be good to add
> > > >> that check too.
> > > >
> > > > So I should do something like
> > > >
> > > > if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WORD_DATA))
> > > > __ __ __ __...
> > > >
> > > > in addition?
> > >
> > > Yes.
> >
> > Ok, here it is.
> >
> > ---
> >
> > Check that SMBUS APIs are available in touchscreen driver.
>
> Why?

Well, the touchscreen driver uses those APIs, and I was told I should
check. It does not matter for htc dream-like machines, but someone
might want to run it on pc...

Pavel


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/