Re: [PATCH -tip] v3 Renamings to increase RCU clarity.

From: Paul E. McKenney
Date: Mon Aug 24 2009 - 11:37:16 EST


On Mon, Aug 24, 2009 at 03:17:57PM +0800, Lai Jiangshan wrote:
> Paul E. McKenney wrote:
> > From: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>

[ . . . ]

> > +static inline void rcu_read_lock_sched_notrace(void)
> > +{
> > + preempt_disable_notrace();
> > +}
>
> It need be marked "notrace". Sometimes a function marked "inline"
> may not be inlined when it is compiled.
>
> Lai.

Good eyes, and thank you -very- much!!! I doubt that I would have ever
spotted this on my own, as I was just assuming that the compiler would
see the preempt_disable_notrace() directly in all cases...

Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/