Re: [PATCH v4 2/5] sched: Record the current active power savingslevel

From: Peter Zijlstra
Date: Mon Aug 24 2009 - 12:10:17 EST


On Tue, 2009-03-31 at 16:20 +0530, Gautham R Shenoy wrote:
> The existing load balancer code is dependent on the sched_mc_power_savings
> variable. However, on multi-core + multi-threaded machines, these decisions
> need to be dependent on the values of both sched_mc_power_savings and
> sched_smt_power_savings.
>
> Create a new variable named active_power_savings_level which is the
> maximum of the sched_mc_power_savings and sched_smt_power_savings.
>
> Record this value in a read mostly global variable at the time when the user
> changes the value of sched_mc/smt_power_savings tunable, and use it for
> load-balancing decisions instead of computing it everytime.

OK, so why keep these variables separate at all?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/