Re: [PATCH 2/3] inotify: do not BUG on idr entries at inotifydestruction

From: Eric Paris
Date: Mon Aug 24 2009 - 16:36:32 EST


On Mon, 2009-08-24 at 12:23 -0700, Linus Torvalds wrote:
>
> On Mon, 24 Aug 2009, Eric Paris wrote:
> >
> > You suspect correctly. :( I'll fix in my tree before I request a
> > pull....
>
> Can you change the WARN() to a WARN_ONCE() too.
>
> Generally, we prefer the "ONCE" variant if there isn't some intrisic
> reason why we'd want to know about each event. If there is some load that
> triggers this, do you care about _how_many_times_ it happens, or about the
> fact that it happens in the first place? In this case, I think it's the
> "happens in the first place" case - once you see it a single time, the
> rest of the reports aren't that interesting.
>
> And using the ONCE thing means that we know it's not going to spam the
> logs.

If everyone having {fs,i}notify problems want to check out my latest
for-linus tree that would be great. It has his latest tree plus fixed
'versions' of the 3 patches I sent earlier.

http://git.infradead.org/users/eparis/notify.git/shortlog/refs/heads/for-linus

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/