Re: [PATCH 1/4] SOUND: atiixp, use uninitialized_var(chip)

[Takashi Iwai]

At Tue, 25 Aug 2009 22:59:34 +0200,
Jiri Slaby wrote:
> 
> To avoid wrong compiler warnings, use unitialized_var(chip) in
> snd_atiixp_probe's from atiixp and atiixp_modem drivers.
> 
> 'chip' is unused when unset due to retval being nonzero.
> 
> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxx>
> Cc: Jaroslav Kysela <perex@xxxxxxxx>

Thanks for patches.  But I'm not sure whether to apply these.
In general, uninitialized_var() should be avoided as much as possible,
and I don't see these warnings in my build systems with a few different
gcc versions.  So, it must be seen only in a very small set of gcc
versions, I guess.  If so, adding this hack is fairly worthless...


Takashi



> ---
>  sound/pci/atiixp.c       |    2 +-
>  sound/pci/atiixp_modem.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c
> index d6752df..436ffea 100644
> --- a/sound/pci/atiixp.c
> +++ b/sound/pci/atiixp.c
> @@ -1648,7 +1648,7 @@ static int __devinit snd_atiixp_probe(struct pci_dev *pci,
>  				     const struct pci_device_id *pci_id)
>  {
>  	struct snd_card *card;
> -	struct atiixp *chip;
> +	struct atiixp *uninitialized_var(chip);
>  	int err;
>  
>  	err = snd_card_create(index, id, THIS_MODULE, 0, &card);
> diff --git a/sound/pci/atiixp_modem.c b/sound/pci/atiixp_modem.c
> index e7e147b..b6191f2 100644
> --- a/sound/pci/atiixp_modem.c
> +++ b/sound/pci/atiixp_modem.c
> @@ -1285,7 +1285,7 @@ static int __devinit snd_atiixp_probe(struct pci_dev *pci,
>  				      const struct pci_device_id *pci_id)
>  {
>  	struct snd_card *card;
> -	struct atiixp_modem *chip;
> +	struct atiixp_modem *uninitialized_var(chip);
>  	int err;
>  
>  	err = snd_card_create(index, id, THIS_MODULE, 0, &card);
> -- 
> 1.6.3.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/