Re: [tip:core/rcu] rcu: Remove lockdep annotations from RCU's_notrace() API members

From: Paul E. McKenney
Date: Wed Aug 26 2009 - 15:11:13 EST


On Wed, Aug 26, 2009 at 08:39:54PM +0200, Ingo Molnar wrote:
>
> * Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
>
> > On Wed, Aug 26, 2009 at 10:49:38AM +0200, Ingo Molnar wrote:
> > >
> > > * tip-bot for Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > > Commit-ID: 06e799764eb7c2e4640888d438c3524d756613e1
> > > > Gitweb: http://git.kernel.org/tip/06e799764eb7c2e4640888d438c3524d756613e1
> > > > Author: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > > > AuthorDate: Tue, 25 Aug 2009 18:53:37 -0700
> > > > Committer: Ingo Molnar <mingo@xxxxxxx>
> > > > CommitDate: Wed, 26 Aug 2009 09:45:41 +0200
> > > >
> > > > rcu: Remove lockdep annotations from RCU's _notrace() API members
> > >
> > > I'm afraid this does not solve the problem either - the attached
> > > config crashes too. Does it boot for you? It should boot fine on
> > > most 64-bit x86 systems.
> >
> > OK, got my hands on a 64-bit x86 system, building. When I did
> > "make oldconfig" on the attached config file, I ended up with the
> > following diffs. If there is some other command I should use,
> > please let me know. Otherwise, will let you know how this goes.
>
> Have you tried it on tip/master + tip/core/rcu? make oldconfig works
> fine with that here.

Ah!!! I have been running just tip/core/rcu.

> But ... here's something you wont like: just to make sure i sent you
> the right config [i made mistakes there in the past] i picked a
> 64-bit system (a different one from the one that triggered the
> crash), built the config with latest tip/master (80c161b, using gcc
> 4.3.2) plus tip/core/rcu (06e7997) git-merged in:
>
> git checkout -b tmp tip/master
> git merge tip/core/rcu
>
> and booted it - and that did not produce any lockups. So you might
> not be able to reproduce it :-/ I've re-merged core/rcu into
> tip/master, maybe my tests can find another config that reproduces
> the crash better. Please disregard this bugreport until i've found
> that one.

OK, I will give the x86_64 machine back and go back to making a
synchronize_rcu_expedited() that is integrated tightly into the tree-rcu
algorithm. Looks to be pretty small and simple -- but then they always
do before you start debugging them... ;-)

Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/