Re: [PATCH 6/7] block: allow large discard requests

[Mark Lord]

Matthew Wilcox wrote:
> On Sat, Aug 29, 2009 at 10:49:02PM -0400, Mark Lord wrote:
> > Pardon my cursory review, but I don't see where this
> > patch set allows for more than a single extent/range
> > of sectors per TRIM command.
>
> It doesn't.
>
> > If it still does not group many extents into a single TRIM,
> > then it will be far to slow to be useful at all for SATA.
>
> That depends on the firmware.  I do have plans to group the extents,
> but let's get something working before making it quick.
..

In this situation, it's more a case of making it *not sucky slow*
than getting to the point where we think about making it "quick".

One extent at a time is glacial.

Cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/