Re: [PULL] http://kernellabs.com/hg/~mkrufky/sms1xxx

[Mauro Carvalho Chehab]

Em Tue, 1 Sep 2009 11:03:14 -0400
Michael Krufky <mkrufky@xxxxxxxxxxxxxx> escreveu:

> The Kconfig symbol names were changed, the target object has changed,
> the module filename has changed.
> 
> A submenu was added, the USB support is not enabled by default.
> 
> None of the above fixed any bug, it just makes unnecessary changes
> that are inappropriate this late in a kernel development cycle.

None of the above breaks anything, and enabling a driver by default is not good
anyway.

> If a bug needed to be fixed, it would have been as simple as adding
> the new object file for smssdio.o , and the old
> DVB_SIANO_SMS1XXX_SMS_IDS section could have been removed without
> changing everything.
> 
> I think this is ridiculous to slip in at the last moment, but I would
> have had no complaints seeing this in the next merge window.
> 
> What is the point of a "merge window" if you let people make such
> changes as this right before a kernel is released.

The patch is a bug fix and it is even older than your LED fix. The first
version were submitted before the previous merge window, and you asked for some
changes that were done accordingly. 

Since the entire Siano driver suffered major changes at the last merge window,
this patch needs to be available together with the remaining series of the
Siano series of patches, to reflect the changes that happened inside the
driver, and the inclusion of the SDIO driver.



Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/