Re: Exporting kmemleak.h to userspace

From: Johannes Berg
Date: Thu Sep 03 2009 - 09:34:39 EST


On Thu, 2009-09-03 at 14:18 +0100, Catalin Marinas wrote:
> On Thu, 2009-09-03 at 09:23 +0300, Pekka Enberg wrote:
> > On Thu, Sep 3, 2009 at 3:29 AM, Luis R. Rodriguez<mcgrof@xxxxxxxxx> wrote:
> > > I was reviewing kmemleak code and noticed kmemleak.h went exported to
> > > userspace under include/linux/kmemleak.h. Do we expect userspace to
> > > use this stuff somehow? All relevant kmemleak structs are kept
> > > private, I'm curious what userspace apps would use this.
> >
> > AFAICT, nobody. Catalin, why is the header exported?
>
> I haven't done anything specifically to export it. It probably gets
> included via other files. Is adding #ifdef __KERNEL__ enough to avoid
> this problem?

It should be exported only if it's listed in Kbuild, which it isn't.
Luis?

johannes

Attachment: signature.asc
Description: This is a digitally signed message part