Re: [RFC][PATCH 2/2] disable boot interrupts on Intel X58 and 55x0

[Daniel Walker]

On Sun, 2009-09-06 at 22:37 -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 05 Sep 2009, Daniel Walker wrote:
> > I'm not sure I see how this makes "adding/deleting/modifying" easier ..
> > We have lots of other situations where lines are broken down less than
> > 80, function arguments, macros, structures all sorts of stuff. 
> > 
> > Taking this block for instance,
> > 
> > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
> >                         PCI_DEVICE_ID_TIGON3_5780,
> >                         quirk_msi_intx_disable_bug);
> > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
> >                         PCI_DEVICE_ID_TIGON3_5780S,
> >                         quirk_msi_intx_disable_bug);
> > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
> >                         PCI_DEVICE_ID_TIGON3_5714,
> >                         quirk_msi_intx_disable_bug);
> > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
> >                         PCI_DEVICE_ID_TIGON3_5714S,
> >                         quirk_msx_intx_disable_bug);
> > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
> >                         PCI_DEVICE_ID_TIGON3_5715,
> >                         quirk_msi_intx_disable_bug);
> > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BROADCOM,
> >                         PCI_DEVICE_ID_TIGON3_5715S,
> >                         quirk_msi_intx_disable_bug);
> 
> You must have an alien brain of some sort if reading that is easier than the
> tabular (single-line) format for you.

My terminal isn't at 130 ..

> Please try finding the one entry in there which is different (I changed one
> of them) with a quick glance.  Chances are you'll just skip over it and
> think all of them do the same thing.

msix , the letters didn't line up, the semicolons don't line up either..
Even with tabs all this information is so similar your bound to overlook
small errors like that. Even if you think all this matter, assume
someone has a term at 80 then every thing is wrapper. That would put you
in the same situation. 

Daniel

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/