Re: [PATCH] Add poll_get_char and poll_put_char uart_ops to atmel_serial.

[Andrew Victor]

hi Albin,

Any reason you're not using the register access macro's like the rest
of the driver?

> +       while (!(__raw_readl(aup->uart.membase + ATMEL_US_CSR) & ATMEL_US_RXRDY))

while (!(UART_GET_CSR(..) & ATMEL_US_RXRDY))

> +       return __raw_readl(aup->uart.membase + ATMEL_US_RHR);

return UART_GET_CHAR(..);

> +       __raw_writel(ch, aup->uart.membase + ATMEL_US_THR);

UART_PUT_CHAR(..., ch);


Otherwise the patch looks fine to me.

Regards,
  Andrew Victor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/