Re: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into.data section.

[Tim Abbott]

On Mon, 7 Sep 2009, Hirokazu Takata wrote:

> From: Tim Abbott <tabbott@xxxxxxxxxxx>
> Subject: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section.
> Date: Sun, 06 Sep 2009 23:12:58 -0400
> > Since these get squashed into the .data output section by the m32r
> > linker script, it seems likely that they don't need their own input
> > sections.
> > 
> > I'd like an explicit confirmation from Hirokazu Takata that this is
> > correct (in particular, that there isn't some hidden reason why there
> > two structures need to be at the start of the .data output section).
> 
> There is no apparent reason.  We've placed them at the start of .data
> section, because they are for initial stack region.
> 
> I think it would be better that we place them to .init.data section.
> Any comment?

Assuming that they aren't used after the initial boot process, that's 
probably the right choice.

	-Tim Abbott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/