Re: [PATCH 1/2] tracing: Add sysctl to enable/disable tracing onoops

[Steven Rostedt]

On Wed, 2009-09-09 at 10:40 +0800, Li Zefan wrote:

> > I have another silly question.
> > Why should we call tracing_off() in oops_enter()?
> > 
> 
> I guess it's because trace outputs generated during oops can
> overwrite/mess up those generated before oops?
> 
> It was added by this commit, but I can't find trace_printk_on_oops.

That's because Thomas did not bother looking up the actual variable he
was talking about. s/trace_printk_on_oops/ftrace_dump_on_oops/

-- Steve

> 
> commit bdff78707f3ce47e891f3201c9666122a70556ce
> Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Date:   Fri Jul 24 15:30:45 2009 -0400
> 
>     trace: stop tracer in oops_enter()
> 
>     If trace_printk_on_oops is set we lose interesting trace information
>     when the tracer is enabled across oops handling and printing. We want
>     the trace which might give us information _WHY_ we oopsed.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/