Re: [patch 3/4 -mm] flex_array: poison free elements

From: David Rientjes
Date: Wed Sep 09 2009 - 00:15:51 EST


On Wed, 9 Sep 2009, Li Zefan wrote:

> > Gack, ftrace_page would probably be better off simply using the flex list
> > implementation I suggested which constructs a list from page->lru since it
> > doesn't appear to require indexing into the array, it simply requires an
> > iteration in all cases (or am I wrong?). Flex lists could easily be made
> > to support seqfiles.
> >
>
> Right, iteration is needed but indexing is not. I thought
> about flex list too, flex array has some limitations which
> make it hard to find a real user.
>

I agree, the cgroup pidarray could be converted into a flex list
implementation as well as ftrace_page, it appears. All the metadata can
be stored by overloading struct page and linking them in a dynamically
expanding list on page->lru.

I'm thinking Andrew will want to see some user of this library in 2.6.32
that cannot be served by a flex list type of implementation if we're to
keep it merged in the kernel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/