Re: BFS vs. mainline scheduler benchmarks and measurements

[Peter Zijlstra]

On Wed, 2009-09-09 at 10:52 +0200, Mike Galbraith wrote:
> @@ -1502,7 +1502,8 @@ static void check_preempt_wakeup(struct rq *rq, struct task_struct *p, int sync)
>          */
>         if (sched_feat(LAST_BUDDY) && likely(se->on_rq && curr != rq->idle))
>                 set_last_buddy(se);
> -       set_next_buddy(pse);
> +       if (sched_feat(NEXT_BUDDY))
> +               set_next_buddy(pse);
>  
>         /*
>          * We can come here with TIF_NEED_RESCHED already set from new task

You might want to test stuff like sysbench again, iirc we went on a
cache-trashing rampage without buddies.

Our goal is not to excel at any one load but to not suck at any one
load.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/