Re: [PATCH V2] x86: SGU UV Add volatile semantics to macros thataccess chipset registers

From: H. Peter Anvin
Date: Wed Sep 09 2009 - 23:06:44 EST


On 09/09/2009 07:22 PM, Jack Steiner wrote:
> Add volatile-semantics to the SGI UV read/write macros that are
> used to access chipset memory mapped registers. No direct
> references to volatile are made. Instead the readq/writeq
> macros are used.
>
> Signed-off-by: Jack Steiner <steiner@xxxxxxx>

The -q part of readq/writeq is qword, 64 bits. It looks like you're
replacing references of other sizes with qword references; was that
intended?

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/